add ToBytes derivation from Circe's Encoder#501
Open
drewfeelsblue wants to merge 1 commit intoevolution-gaming:masterfrom
Open
add ToBytes derivation from Circe's Encoder#501drewfeelsblue wants to merge 1 commit intoevolution-gaming:masterfrom
ToBytes derivation from Circe's Encoder#501drewfeelsblue wants to merge 1 commit intoevolution-gaming:masterfrom
Conversation
Author
|
hi, @BrainHorse. Could you pls review? |
mr-git
changed the title
toBytes derivation from Circe's Encoder
mr-git
changed the title
toBytes derivation from Circe's EncoderToBytes derivation from Circe's Encoder
Contributor
|
It would be lovely to have unit-tests too, also for |
Author
|
@mr-git sure, have nothing against it but... I wonder what kind of tests could be valuable for such a code. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.