fix: accurate query time display and system table preview#43
Closed
abdullah094 wants to merge 3 commits intomainfrom
Closed
fix: accurate query time display and system table preview#43abdullah094 wants to merge 3 commits intomainfrom
abdullah094 wants to merge 3 commits intomainfrom
Conversation
Replace Date.now() with performance.now() for sub-millisecond precision and introduce adaptive formatDuration() utility that shows "45ms" for fast queries, "1.2s" for multi-second, and "1m 15s" for long-running. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
System tables (SYS, EXA_STATISTICS) now open a SELECT * LIMIT 100 data preview on double-click instead of column metadata. Regular tables and views continue showing column metadata unchanged.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
abdullah094
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Query Notifications & Timing Fix
exasol.showQueryNotificationssetting to toggle notifications on/offDate.now()toperformance.now()acrossqueryExecutor.ts,objectActions.ts, andextension.tsfor sub-millisecond precision (fixes "0.0s" display)formatDuration()utility that adapts units (ms/s/m) based on magnitudeSystem Table Double-Click Preview
system-tablecase in ObjectTreeItem constructor and branchedexasol.openObjecthandlerTest Coverage
All new code paths have test coverage (14/14 paths, 100%).
Tests: 29 files, 233 tests passing.
New test files:
formatDuration.test.ts— 5 tests covering all duration rangesqueryNotifications.test.ts— 12 tests covering success, failure, batch, suppressionPre-Landing Review
Pre-Landing Review: No issues found.
Specialist review: 1 informational finding (DRY: config check repeated 4x). No critical issues.
PR Quality Score: 9.5/10
Adversarial Review
Claude adversarial: informational UX observations only (notification overlap, fixed timeout). No correctness bugs.
Codex: unable to complete (sandbox read-only policy blocked file access).
Scope Drift
Scope Check: DRIFT DETECTED
Intent: Fix query time display showing 0.0s
Delivered: Query time fix + system table double-click preview (bundled)
Note: System table preview was implemented during this session and shipped together.
Test plan
npm run compile)🤖 Generated with Claude Code