[FIX] strip NUL padding from token content before rendering (CJK grid tables) (#95)#96
Open
coxxny wants to merge 4 commits intoexecutablebooks:mainfrom
Open
[FIX] strip NUL padding from token content before rendering (CJK grid tables) (#95)#96coxxny wants to merge 4 commits intoexecutablebooks:mainfrom
coxxny wants to merge 4 commits intoexecutablebooks:mainfrom
Conversation
Author
|
This PR contains a fix for ReadTheDocs configuration so the docs build succeeds. |
Author
|
Hi, just a friendly ping. This PR has been open for about 2 months, so I just wanted to kindly check if this PR is still on your radar or if there's anything I can do to help move it forward. Thanks for maintaining this project. I appreciate your work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
#95
Summary
This PR fixes a crash when converting an
.rstfile that contains a grid table with double-width characters (e.g. Japanese).Root cause: Docutils pads double-width characters during table parsing by temporarily inserting a NUL (\x00) sentinel. In the RST→MyST path (Docutils AST → markdown-it tokens → renderer), that NUL can remain in token content and reach the Markdown renderer, which then errors out.
Fix: Right before rendering, recursively strip \x00 from token content. This keeps the renderer from ever seeing embedded NULs. The change is minimal and localized to the rendering step.
Minimal Reproduction
test.rstBefore
After
test
pre-commit result