Toggle combined details with Option key - #3229
Open
IonBazan wants to merge 1 commit into
Open
Conversation
Owner
|
about this one, the realization maybe ok but, I'm not sure this feature will be added to the Stats. |
|
A macOS 27 note for whenever this gets rebased: inside the status-item button action, the event from NSApp.currentEvent arrives with modifierFlags stripped (type is still leftMouseDown, flags 0x0 while Option is held), so the Option check never fires. Reading the live keyboard state via the static NSEvent.modifierFlags property works on both 26 and 27 — same idea as the cursor-position module resolution master uses since aff3175. I'm carrying this PR (authorship kept) with that adaptation in my fork, verified on 26.5 and 27.0: kk1987@764b087c |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows toggling between "combined details" view using Option (⌥) key as proposed in #3223.
I decided to use Option key instead of Shift/Right click as it keeps it consistent with other native Mac OS widgets (Wi-Fi).
Note that this feature works by inverting the behaviour selected in "combined details" depending on key combination.
Fixes #3223