Skip to content

Tweak pangram tests per canonical-data #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Tweak pangram tests per canonical-data #153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions exercises/practice/pangram/.meta/config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@
"authors": [
"lpil"
],
"contributors": [
"kytrinyx"
],
"files": {
"solution": [
"src/pangram.gleam"
Expand Down
4 changes: 2 additions & 2 deletions exercises/practice/pangram/test/pangram_test.gleam
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ pub fn missing_letters_replaced_by_numbers_test() {
}

pub fn mixed_case_and_punctuation_test() {
let sentence = "Five quacking Zephyrs jolt my wax bed."
let sentence = "\"Five quacking Zephyrs jolt my wax bed.\""
assert True = is_pangram(sentence)
}

Expand All @@ -55,7 +55,7 @@ pub fn case_insensitive_test() {
assert False = is_pangram(sentence)
}

pub fn a_m_and_upper_a_m_are_26_different_characters_but_not_a_pangram_test() {
pub fn a_m_and_a_m_are_26_different_characters_but_not_a_pangram_test() {
Copy link
Contributor

@jiegillet jiegillet Jan 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the previous title was better, lost in generation I suppose

Copy link
Member Author

@kytrinyx kytrinyx Jan 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, yeah you're right, they get lost in the generation. I'm going to see if I can improve the test title upstream and regenerate.

let sentence = "abcdefghijklm ABCDEFGHIJKLM"
assert False = is_pangram(sentence)
}