fix: Fix binary resource streaming in JitsiGateway to prevent 0 KB assets EXO-72351 #163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jihed525
approved these changes
Sep 12, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, JitsiGateway.forward() incorrectly handles all HTTP responses by converting them to text using EntityUtils.toString(). This corrupts binary resources such as images, PDFs, and other static assets when proxied through the gateway, resulting in 0 KB files.
Changes made:
Binary responses (non-JSON) are now streamed directly to the client using OutputStream instead of Writer.
JSON responses continue to be handled as text.
Ensures that images like logo.png served via /jitsi/images/ are delivered correctly.
This fix resolves the issue where proxied static resources appear empty and preserves proper handling of both JSON and binary content.