-
Notifications
You must be signed in to change notification settings - Fork 28
Remove last dependecies on egoscale v2 #736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
tgrondier
wants to merge
13
commits into
master
Choose a base branch
from
tgrondier/feat/egoscalev2-cleanup
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+211
−967,101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgrondier
commented
Jul 16, 2025
@@ -1,4 +1,4 @@ | |||
package api | |||
package x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initially in egoscale/v2
, this file is made obsolete by egoscale v3; however it's still useful for arbitrary calls such as the ones required by x, so it would make sense to move it here.
➜ ~/exo/cli git:(tgrondier/feat/egoscalev2-cleanup) ✗ go run . limits 25-07-03 9:54 ┼──────────────────────────────────────────┼──────┼───────┼ │ RESOURCE │ USED │ MAX │ ┼──────────────────────────────────────────┼──────┼───────┼ │ Max size of a Block Storage Volume (GiB) │ 0 │ 10240 │ │ Elastic IP addresses │ 0 │ 20 │ │ IAM API keys │ 25 │ 100 │ │ Compute instance GPUs │ 0 │ 1 │ │ Private networks │ 1 │ 32 │ │ Compute instances │ 2 │ 100 │ │ Compute instance templates │ 1 │ 30 │ │ Network Load Balancers │ 0 │ 50 │ │ Compute instance snapshots │ 2 │ 45 │ │ Block Storage cumulative size (GiB) │ 110 │ 20480 │ │ SKS clusters │ 0 │ 3 │ │ SOS buckets │ 4 │ 199 │ │ Block Storage Volumes │ 2 │ 1000 │ ┼──────────────────────────────────────────┼──────┼───────┼
➜ ~/exo/cli git:(tgrondier/feat/egoscalev2-cleanup) ✗ go run . compute sks deprecated-resources jouhoushoribu 25-07-16 14:52 ┼──────────────────┼─────────────────┼─────────────────────┼─────────────┼─────────┼ │ GROUP │ REMOVED RELEASE │ RESOURCE │ SUBRESOURCE │ VERSION │ ┼──────────────────┼─────────────────┼─────────────────────┼─────────────┼─────────┼ │ discovery.k8s.io │ │ endpointslices │ │ v1beta1 │ │ policy │ │ podsecuritypolicies │ │ v1beta1 │ ┼──────────────────┼─────────────────┼─────────────────────┼─────────────┼─────────┼
82e6ed8
to
2c30e6c
Compare
63c716e
to
dfa7570
Compare
dfa7570
to
35eb692
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes all the last dependencies of the exoscale client on egoscale v2
Checklist
(For exoscale contributors)
Testing
Test in individual commits