Skip to content

fix: need ot encode post body as utf-8 to avoid exceptions on TestSet.upload() #1968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: need ot encode post body as utf-8 to avoid exceptions on TestSet.upload() #1968

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ragas/sdk.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ def upload_packet(path: str, data_json_string: str):

response = requests.post(
f"{base_url}/api/v1{path}",
data=data_json_string,
data=data_json_string.encode('utf-8'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change may fix UTF-8 encoding issues but introduces potential runtime errors if data_json_string isn't always a string type.

Consider adding a type checking:

data=data_json_string.encode('utf-8') if isinstance(data_json_string, str) else data_json_string,

something like that.

headers=headers,
timeout=(connection_timeout, read_timeout),
)
Expand Down