pmtud: base should fallback to MIN_PLPMTU when INITIAL_PLPMTU failed #199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When INITIAL_PLPMTU probe failed, MIN_PLPMTU is tried but the base is not updated. Since calculation of the next probe size is based on the base, it never drops below INITIAL_PLPMTU. Setting base to MIN_PLPMTU would fix this issue.
kp-max-li
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When INITIAL_PLPMTU probe failed, MIN_PLPMTU is tried but the base is not updated. Since the calculation of the next probe size is based on the base, it never drops below INITIAL_PLPMTU.
Setting base to MIN_PLPMTU would fix this issue.
How Has This Been Tested?
Manually tested
Types of changes
Checklist:
main