Skip to content

Conversation

@LuoZijun
Copy link

@LuoZijun LuoZijun commented Oct 7, 2018

  1. upgrade regex to 1.0.
  2. fix mod path on nightly version.
  3. fix test unicode version ( b9677f0 )

@eyeplum
Copy link
Owner

eyeplum commented Oct 9, 2018

Thanks for your pull request.

However since this is merely a fork of open-i18n/rust-unic, I'd suggest you to send pull requests to the orignial repo.

Also I see you are merging into ucd/unihan, if you have any suggestions to the existing implementation I will be more than happy to discuss it in open-i18n#225. Also as we have disucssed in open-i18n#255, the current implementation is waiting for a refactor of how rust-unic does Unicode character database parsing (which would likely affect the current implementation of Unihan data parsing quite heavily).

谢谢你的理解。

@eyeplum eyeplum closed this Oct 13, 2018
@LuoZijun
Copy link
Author

目前为止,考虑到 ucd/unihan 的具体实现还未出现,所以我并没有什么建议。

我尝试合并你的 PR 分支是因为这个 PR 似乎停滞了相当长的一段时间,所以我打算先使用下你当前的分支。考虑到我个人一直是在 Nightly 版本里工作的,所以出现了一些模块路径问题。

我会持续关注该 PR 的进度。

谢谢你所做的工作。


So far, I don't have any suggestions considering that the implementation of ucd/unihan has not yet appeared. I'm trying to merge your PR branch because this PR seems to have stalled for quite a while, so I'm going to use your current branch first.

Given that I personally have been working in the Nightly version, there have been some module path problems.

I will continue to pay attention to the progress of the PR. Thank you for the work you have done.

-- From Bing Translator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants