Closed
Conversation
jbeard6
requested review from
azizkarakhanyan-ezcater and
pinkertonpg
and removed request for
a team
Author
|
Oh. Nevermind on this one. |
|
Not sure why I'm getting notified about this PR like a decade after I last worked at ezCater, but I am for some reason. |
|
@wins32767 Please rewrite this in Go, please. LOL. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What did we change?
Added DockerHub credentials when pulling images during CI.
Why are we doing this?
DEVEX-3429
We're accidentally DOS-ing ourselves from pulling Docker images during CI runs. Every pull that isn't authenticated puts us one step closer to hitting Docker's Abuse rate limit. We have been hitting this on a semi-regular basis lately, which requires developers to babysit CI through multiple attempts until either we fall far enough below the abuse threshold or jobs get assigned to an alternate runner IP that has not yet hit its limit.