-
Notifications
You must be signed in to change notification settings - Fork 0
코드 스플리팅 작업 및 API요청시 Retry, keepalive 기능 추가 #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sunnykim91
wants to merge
8
commits into
develop
Choose a base branch
from
refactor/split
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dev-boku
reviewed
Jul 31, 2025
height, | ||
style, | ||
}: OptimizedImageProps) => { | ||
const [isLoaded, setIsLoaded] = useState(false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- onLoad가 보여지기 전까지는 fallback 이미지도 보여줘야겠죠
- 스켈레톤 로딩 기능
- prefetch 기능을 구현하는데 이 때 캐시를 이용해보시면 좋아요
- Intersection Observer를 이용해서 element의 위에 offset 부근에 닿으면 fetch로 이미지를 미리 불러와서 보여지도록 만들 수 있음
width: number; | ||
height: number; | ||
style?: React.CSSProperties; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
PR 유형
어떤 변경 사항이 있나요?
PR Checklist
PR이 다음 요구 사항을 충족하는지 확인하세요.
이미지 or 영상 (선택)
light house 측정 링크 : https://sunnykim91.notion.site/lighthouse-23d164b79d5e8023a684fe38116a2799?source=copy_link
참고한 자료 (선택)
참고한 자료가 있으면 링크를 남겨주세요.