Skip to content

feat: floating window for blame message - #151

Open
davidgao7 wants to merge 2 commits into
f-person:mainfrom
davidgao7:blame-floating-window
Open

feat: floating window for blame message#151
davidgao7 wants to merge 2 commits into
f-person:mainfrom
davidgao7:blame-floating-window

Conversation

@davidgao7

@davidgao7 davidgao7 commented May 26, 2025

Copy link
Copy Markdown
Contributor

hello!

I found it's kind of hard to see the full commit message when using virtual text, so I created a command to display a floating window so we don't have to resize my terminal every time

Screenshot 2025-05-26 at 5 36 18 PM

@jinzhongjia

Copy link
Copy Markdown
Contributor

@f-person Hey, bro. Can we merge this PR?
I think this is a great feat!

@davidgao7

Copy link
Copy Markdown
Contributor Author

Any updates guys?

@f-person

f-person commented Jan 8, 2026

Copy link
Copy Markdown
Owner

hi! thanks for the PR! it's a nice idea, and it would be great to add a floating window to the plugin at some point.
however, i checked it, and it's not ready to merge as-is, because the implementation is incomplete.
mainly, the UX around the blame message window is poor (e.g., the command opens the window, but it doesn't, for example, disappear once cursor is moved elsewhere or it doesn't follow the cursor). not fully sure what the ideal UX should be either.
also, there should be configuration options for what to show in the floating window.

i might pick it up myself sometime, after i see how other plugins usually implement the floating window UX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants