Fix Windows path compatibility for npx check-ai#5
Merged
Merged
Conversation
Contributor
Author
|
@f Windows users are waiting for the ‘merged’ news 😅 |
Owner
|
Deployment fails. Can you fix the CI issue and resend a PR? |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npx check-aiwas throwing the following error on Windows due to how absolute paths were being handled by the Node.js ESM loader:This happens because Windows absolute paths (e.g.
C:\...) are not valid ESM URLs. The Node.js ESM loader expects paths to be provided asfile://URLs.To fix this, the Node.js native
pathToFileURLutility is used to convert filesystem paths into OS-safefile://URLs before loading them.