segbits_hclk_ioi: fix missing ONLY_DIFF_IN_USE#2249
Open
hansfbaier wants to merge 1 commit intof4pga:masterfrom
Open
segbits_hclk_ioi: fix missing ONLY_DIFF_IN_USE#2249hansfbaier wants to merge 1 commit intof4pga:masterfrom
hansfbaier wants to merge 1 commit intof4pga:masterfrom
Conversation
hansfbaier
force-pushed
the
030-iob18-hclk-fix
branch
from
d2502a0 to
30ab5d0
Compare
Collaborator
Author
|
Now the mentioned comment is gone, because I fixed the problem at the source. |
Collaborator
Author
|
Problem was, since LVDS is the only ONLY_DIFF IO standard on the high performance banks, ONLY_DIFF_IN_USE and LVDS_IN_USE are synomynous, which means they have the same bits, and that's why dbfixup removed both. |
hansfbaier
added a commit
to openXC7/prjxray-db
that referenced
this pull request
Oct 12, 2023
hansfbaier
force-pushed
the
030-iob18-hclk-fix
branch
from
30ab5d0 to
5539551
Compare
Signed-off-by: Hans Baier <hansfbaier@gmail.com>
hansfbaier
force-pushed
the
030-iob18-hclk-fix
branch
from
5539551 to
0c5dc38
Compare
Collaborator
Author
|
@mithro Can this be merged? All relevant tests are green, and this is a change to the code I contributed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think the comment in the code is pretty much explaining the fix.