WIP: Rails 6.1 - disabled rocket_pants #585
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default we require all Rails frameworks but, when ActiveStorage got added, but we do not use. Best to just disable so not conflig or useless configs/migrations. In future rails app:update is required to add new frameworks manually.
This was already removed from the homepage, so we can remove controller logic too.
No reason to use a EOL version, and only used to download packages.
Seems now Rails 6 is more strict with the validate line and hardcoded IDs in factory. Also let us run the tests with the lab refree validation to be sure passes, bad habbit to hide during tests code. Created factories for labs with apprval refrees so validation passes.
Move simple /0/labs, admin routes, and oauth me to new route. Install new api serializer to work with Ruby3.
We can add back slowly what is requested from these commits.
Also removed protected_attributes as not used.
Should upgrade to Dart Sass and the sass-embedded gem. Removed the Trubowyg text-editor as was holding back upgrade and was not working and used only in Pages.
Also pinned admin gem and removed twitter, deprecated and not used.
Not sure why we have hardcoded test UA header, needs to be changed with each gem update.
When building the jobs search form, ransack needs the relations white listed.
# Conflicts: # Gemfile.lock # app/views/application/_header.html.haml # config/environments/production.rb # config/puma.rb
Not sure why this threw exception now, but something changed in upgrades.
To give external platforms time to migrate to new urls, have both domains working.
We can use to know when we can turn the old subdomain off.
Not sure why this method was overwritten, but caused issue with upgrades. To just stick to a RackTest driver and avoid custom logic, added a simple hidden search button so can be clicked by tests. Also good for accessibility.
Seems the recent capybara upgrade broke the lab create test in relation to multi-select referee selection and the validation. Seems RakeTest does not submit data in expected way. Maybe with future rails upgrades this will be fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #584 has a todo list on what needs to be done for this PR.
This PR is an example on how to start the upgrade to Rails 6 (tests are still failing due to
rocket_pantsremoval)