Improve compatibility with Windows bitmaps#3
Open
PluMGMK wants to merge 2 commits intofabvalaaah:masterfrom
Open
Improve compatibility with Windows bitmaps#3PluMGMK wants to merge 2 commits intofabvalaaah:masterfrom
PluMGMK wants to merge 2 commits intofabvalaaah:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! These are a couple of enhancements I made while using this to test out RLE bitmaps produced by my Windows 3.1 GDI driver.
The first change is to handle compression of DIBs that don't have the image size field filled out in the bitmap header. Windows drivers can produce and consume DIBs with this field set to zero, in which case the size is inferred from the width, height and depth, so I implemented this behaviour here.
The second is to handle decompression of RLE bitmaps that contain absolute (i.e. uncompressed) sequences. This tool doesn't produce such sequences, but being able to consume them is needed to handle bitmaps from other sources.
This doesn't cover "skip" sequences which allow the decoding to move around the frame, so decompressing bitmaps containing those will probably still crash the tool, but I think most cases are covered without that…