Skip to content

Conversation

@asukaminato0721
Copy link
Contributor

@meta-cla meta-cla bot added the cla signed label Nov 1, 2025
@asukaminato0721 asukaminato0721 marked this pull request as ready for review November 2, 2025 15:59
@meta-codesync
Copy link

meta-codesync bot commented Nov 3, 2025

@kinto0 has imported this pull request. If you are a Meta employee, you can view this in D86121244.

}
}
},
"python.pyrefly.analysis.inlayHints": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it work like this? according to the docs, it needs python.pyright.analysis.inlayHints. could we make sure the documentation is up to date?

@asukaminato0721
Copy link
Contributor Author

did some tests

    "python.pyrefly.analysis.inlayHints.callArgumentNames": "all",
image
"python.pyrefly.analysis.inlayHints.callArgumentNames": "off",

no inlay hint

"python.pyright.analysis.inlayHints.callArgumentNames": "all",

no

So the doc is a bit outdated?

@kinto0
Copy link
Contributor

kinto0 commented Nov 11, 2025

hmm, I think this is a bug. it seems like analysis will always be handled since the addition of pyrefly.analysis.disabledLanguageService

but we don't use the default analysis config if we have handled one

Copy link
Contributor

@kinto0 kinto0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed the bug in #1541, #1542, #1543 and updated documentation

if you want these settings, we should expose them using python.analysis. we should ensure we test it with the python extension as well to make sure they don't collide (i'm not sure what happens if two extensions register the same setting)

@asukaminato0721
Copy link
Contributor Author

Thanks for the clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show inlay hint for parameter names of positional arguments

2 participants