fix Simple alias to typing.Annotated is not recognized #1488 #1502
+121
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stroxler
reviewed
Nov 10, 2025
Contributor
stroxler
left a comment
stroxler
left a comment
There was a problem hiding this comment.
This looks pretty good to me!
Back to you to think about whether we can drop phi support for now, and a few style nits
stroxler
approved these changes
Nov 11, 2025
Contributor
stroxler
left a comment
stroxler
left a comment
There was a problem hiding this comment.
Looks reasonable to me, I'll try to get it merged
yangdanny97
approved these changes
Nov 14, 2025
Contributor
yangdanny97
left a comment
yangdanny97
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1488
Exposed binding_idx_for_name so bindings logic can inspect the current flow’s key and style when resolving aliases
Updated special-export detection to follow NameAssign/phi chains with cycle guards, allowing assignment aliases to inherit their source special form
Stopped treating bare Annotated assignments as implicit type aliases so aliasing the special form no longer triggers invalid-annotation errors