fix Feat: Expand **kwargs with field names on hover when **kwargs is typed with Unpack (i.e. **kwargs: Unpack[T]) #758 #1514
+158
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangdanny97
reviewed
Nov 6, 2025
| if let Some(fields) = collect_typed_dict_fields_for_hover(solver, ty) { | ||
| changed = true; | ||
| for (field_name, field_type, required) in fields { | ||
| expanded.push(Param::KwOnly(field_name, field_type, required)); |
Contributor
There was a problem hiding this comment.
Since required parameters can't come after non-required ones (there isn't a type checking issue here, just looks weird when we display it), we'd probably want to put the required TypedDict fields ahead of any non-required parameters. After the list is expanded, we can partition expanded by required-ness to make the new list.
yangdanny97
requested changes
Nov 6, 2025
Contributor
yangdanny97
left a comment
yangdanny97
left a comment
There was a problem hiding this comment.
Rest of it LGTM, just the parameter sorting issue
yangdanny97
reviewed
Nov 6, 2025
yangdanny97
reviewed
Nov 6, 2025
yangdanny97
reviewed
Nov 6, 2025
|
@yangdanny97 has imported this pull request. If you are a Meta employee, you can view this in D86638374. |
kinto0
approved these changes
Nov 11, 2025
Contributor
kinto0
left a comment
kinto0
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
|
@yangdanny97 merged this pull request in 165ee55. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #758
Hover output now expands **kwargs typed with typing.Unpack[TypedDict] into their constituent keyword-only parameters so people hovering a call see the real argument names.
Implemented the expansion by letting HoverValue accept a pre-computed display string, formatting callables via transaction.ad_hoc_solve, and inserting typed-dict fields as synthetic Param::KwOnly entries before the original **kwargs.