fix auto complete dict key when possible #1189 #1515
+429
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinto0
reviewed
Nov 6, 2025
kinto0
reviewed
Nov 7, 2025
kinto0
approved these changes
Nov 10, 2025
| items: int | ||
| td: TD = {'items': 1} | ||
| assert_type(td['items'], int) | ||
| assert_type(td['items'], Literal[1]) |
Contributor
There was a problem hiding this comment.
could this mean it's harder to add items to a typeddict (i.e. all additions must be literal[1] and not int?
Contributor
Author
There was a problem hiding this comment.
so td['items'] = 2 will fail but td['items'] = a int value will pass now. A bit too strict.
Contributor
There was a problem hiding this comment.
@asukaminato0721 could we factor just the facet narrows out into a separate PR?
There's a lot of lsp logic in this change, but the typing implications are - I think - entirely due to the new facet narrows and we could focus on those separately
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1189
Introduced dict key completions: added facet chains and literal facet propagation.