Skip to content

Conversation

lavenzg
Copy link
Contributor

@lavenzg lavenzg commented Aug 26, 2025

Differential Revision: D81087047

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 26, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D81087047

@react-native-bot
Copy link
Collaborator

react-native-bot commented Aug 26, 2025

Fails
🚫

❔ This pull request needs a description.

Generated by 🚫 dangerJS against 8bc8fbf

lavenzg added a commit to lavenzg/react-native that referenced this pull request Aug 28, 2025
Summary:



Rollback Plan:

Differential Revision: D81087047
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D81087047

lavenzg added a commit to lavenzg/react-native that referenced this pull request Aug 28, 2025
Summary:



Rollback Plan:

Differential Revision: D81087047
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D81087047

lavenzg added a commit to lavenzg/react-native that referenced this pull request Aug 29, 2025
…acebook#53475)

Summary:

This is cleanup of IHermesExtra. Move the last method in IHermesExtra,
dumpOpcodeStats(), to jsi::Instrumentation, since other profile stats
dumping methods live in that interface as well.

Differential Revision: D81087047
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D81087047

lavenzg added a commit to lavenzg/react-native that referenced this pull request Aug 29, 2025
…acebook#53475)

Summary:
Pull Request resolved: facebook#53475

This is cleanup of IHermesExtra. Move the last method in IHermesExtra,
dumpOpcodeStats(), to jsi::Instrumentation, since other profile stats
dumping methods live in that interface as well.

Differential Revision: D81087047
@lavenzg lavenzg force-pushed the export-D81087047 branch 2 times, most recently from abfe7eb to 60ec141 Compare September 2, 2025 18:31
lavenzg added a commit to lavenzg/react-native that referenced this pull request Sep 2, 2025
…acebook#53475)

Summary:

This is cleanup of IHermesExtra. Move the last method in IHermesExtra,
dumpOpcodeStats(), to jsi::Instrumentation, since other profile stats
dumping methods live in that interface as well.

Differential Revision: D81087047
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D81087047

lavenzg added a commit to lavenzg/react-native that referenced this pull request Sep 2, 2025
…acebook#53475)

Summary:
Pull Request resolved: facebook#53475

This is cleanup of IHermesExtra. Move the last method in IHermesExtra,
dumpOpcodeStats(), to jsi::Instrumentation, since other profile stats
dumping methods live in that interface as well.

Differential Revision: D81087047
Differential Revision: D80740969
Differential Revision: D80747463
…race, [SH] Move dumpSampledTraceToProfile() to IHermes

Differential Revision: D81075460
lavenzg added a commit to lavenzg/react-native that referenced this pull request Sep 3, 2025
…acebook#53475)

Summary:

This is cleanup of IHermesExtra. Move the last method in IHermesExtra,
dumpOpcodeStats(), to jsi::Instrumentation, since other profile stats
dumping methods live in that interface as well.

Reviewed By: tsaichien

Differential Revision: D81087047
…acebook#53475)

Summary:
Pull Request resolved: facebook#53475

This is cleanup of IHermesExtra. Move the last method in IHermesExtra,
dumpOpcodeStats(), to jsi::Instrumentation, since other profile stats
dumping methods live in that interface as well.

Reviewed By: tsaichien

Differential Revision: D81087047
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D81087047

facebook-github-bot pushed a commit to facebook/hermes that referenced this pull request Sep 4, 2025
Summary:
X-link: facebook/react-native#53475

This is cleanup of IHermesExtra. Move the last method in IHermesExtra,
dumpOpcodeStats(), to jsi::Instrumentation, since other profile stats
dumping methods live in that interface as well.

Changelog: [Internal]

Reviewed By: tsaichien

Differential Revision: D81087047

fbshipit-source-id: e145aafea7459a161fca04ffc30f0838ee6c03c6
facebook-github-bot pushed a commit to facebook/hermes that referenced this pull request Sep 4, 2025
Summary:
X-link: facebook/react-native#53475

This is cleanup of IHermesExtra. Move the last method in IHermesExtra,
dumpOpcodeStats(), to jsi::Instrumentation, since other profile stats
dumping methods live in that interface as well.

Changelog: [Internal]

Reviewed By: tsaichien

Differential Revision: D81087047

fbshipit-source-id: e145aafea7459a161fca04ffc30f0838ee6c03c6
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Sep 4, 2025
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 863184f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants