[iOS] Use autolinking react-native-config output in iOS artifacts generator

[kitten]

Summary:

Resolves #53501

This is a pretty major oversight of (presumably) the old autolinking refactor. The iOS autolinking's second stage, invoked in use_react_native! does not accept the react-native-config sub-command's react-native-config output. This is only invoked and used in the prior step, use_native_modules.

The second step instead invokes old code that does something similar to the new autolinking in scripts/generate-artifacts-executor, and happens to align in most cases. (But it does "autolinking" from scratch). tl;dr: When the results don't match up, things go wrong.

Instead, we now write the autolinking (react native config) results to a file, then read the output back in the second step.

This doesn't affect Android/Gradle, which are implemented correctly.

Changelog:

[IOS] [FIXED] - Use autolinking-generated react-native-config output in second step of cocoapods linking that generates artifacts and generated source

Test Plan:

• See Codegen doesn't use autolinking on iOS #53501 for failing repro
• Clone for working repro: https://github.com/byCedric/react-native-codegen-ios-autolinking/tree/fix-54503
  • Note: Contains this PR's changes as a patch
  • bun install
  • bun expo run:ios

[cipolleschi]

code makes sense, but there is one important part that needs to be addressed.

[kitten]

I'm having some trouble building on main (hermes-engine isn't picking up a prebuilt for me, if that's what's supposed to happen and build fails w/o target for libhermes). I picked this change over to 0.81-stable, and rn-tester builds fine with and without these changes. I ran the legacy and turbo module tests and they completed as expected.

0.81-stable...kitten:react-native:@kitten/0.81-stable/fix/pick-broken-ios-autolinking

I'll have to look at the lint failures but the flow-bin isn't running for me and a version that's one minor behind isn't matching the flow check failures in the CI tests

[cipolleschi]

Talked at the CCS with @byCedric. I think this is good to go, as soon as the linting and JS tests are fixed.

[kitten]

Should be back to normal and passing. Rebased on main which also allowed me to check flow check manually. Main issues was console.warn -> codegenLog being needed, and an invalid FlowFixMe pragma on the require call

[facebook-github-bot]

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this in D81490755.

[cortinico]

Review automatically exported from Phabricator review in Meta.

[react-native-bot]

This pull request was successfully merged by @kitten in f170db4

^{When will my fix make it into a release? | How to file a pick request?}

[facebook-github-bot]

@cipolleschi merged this pull request in f170db4.