Mark JavaTimerManager idle callback methods as @LegacyArchitecture #53570
+27
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Simplify construction to save a JNI call, slightly more efficient on binary size too (1KiB hah) Changelog: [Internal] Differential Revision: D81445834
Summary: Idle callbacks are implemented as a C++ module in the new architecture, this code should not be used. Differential Revision: D81485912
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D81485912 |
cortinico
approved these changes
Sep 2, 2025
|
This pull request has been merged in 2ed6a08. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Idle callbacks are implemented as a C++ module in the new architecture, this code should not be used.
Differential Revision: D81485912
Changelog: [Internal]