Skip to content

Replace regex Captures::get(0).unwrap() with get_match() #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ship-it-ship-it wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −5
Open

Replace regex Captures::get(0).unwrap() with get_match() #157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion starlark_lsp/src/definition.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -658,7 +658,7 @@ pub(crate) mod helpers {

let mut fixture_idx = 0;
for matches in re.captures_iter(fixture) {
let full_tag = matches.get(0).unwrap();
let full_tag = matches.get_match();
let is_end_tag = matches.get(1).is_some();
let identifier = matches.get(2).unwrap().as_str().to_owned();

Expand Down
5 changes: 1 addition & 4 deletions starlark_lsp/src/test.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,10 +235,7 @@ impl LspContext for TestServerContext {
let start_pos = cap.get(1).unwrap().as_str().parse().unwrap();
let end_pos = cap.get(2).unwrap().as_str().parse().unwrap();
let span = Span::new(Pos::new(start_pos), Pos::new(end_pos));
(
literal[0..cap.get(0).unwrap().start()].to_owned(),
Some(span),
)
(literal[0..cap.get_match().start()].to_owned(), Some(span))
}
None => (literal.to_owned(), None),
};
Expand Down