refactor: Remove const_cast and const_pointer_cast#734
Open
PingLiuPing wants to merge 1 commit intofacebookincubator:mainfrom
Open
refactor: Remove const_cast and const_pointer_cast#734PingLiuPing wants to merge 1 commit intofacebookincubator:mainfrom
PingLiuPing wants to merge 1 commit intofacebookincubator:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
|
@amitkdutta has imported this pull request. If you are a Meta employee, you can view this in D90277850. |
Contributor
|
@PingLiuPing Theres is merge conflict. Please take a look. |
hdikeman
reviewed
Jan 9, 2026
| } | ||
|
|
||
| void LocalHiveConnectorMetadata::ensureInitialized() const { | ||
| std::lock_guard<std::mutex> l(mutex_); |
Contributor
There was a problem hiding this comment.
Since this function was removed, do we still need the mutex?
I thought this was to guard against the case where multiple threads invoke ensureInitialized(). Could you double check
Author
There was a problem hiding this comment.
@hdikeman Thanks for the comment.
I noticed that mutex_ is not only used here, it is used in many other places too such as findTable, dropTable etc.
PingLiuPing
force-pushed
the
lp_refactor_const_cast
branch
2 times, most recently
from
503791f to
e7f55b5
Compare
PingLiuPing
force-pushed
the
lp_refactor_const_cast
branch
from
e7f55b5 to
7fda812
Compare
PingLiuPing
force-pushed
the
lp_refactor_const_cast
branch
from
7fda812 to
78d11b7
Compare
Author
@amitkdutta Conflicts has been resolved. Could you help to import this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #324.