add datamodule to trainer.test() in OSS train_eval_lightning #583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Pull Request resolved: facebookresearch#408 Reviewed By: czxttkl Differential Revision: D26635649 fbshipit-source-id: 9d6a3aa554dfa91b431c9e9e6785625f71c2ae66
) Summary: Pull Request resolved: facebookresearch#410 Once we dedupe workflow directories, we can add autodeps. For now we can get close. Reviewed By: czxttkl Differential Revision: D26772795 fbshipit-source-id: 070bc3d2982155452a658c92b1f56af10336afb9
Reviewed By: czxttkl Differential Revision: D26809740 fbshipit-source-id: e51aada18b9d31ae5b5ce71f0b30addf315c50e6
…er files Summary: Generalized ips_use_cases.py, added some comments and printing to other files Reviewed By: kaiwenw Differential Revision: D26878973 fbshipit-source-id: 4025d076dbd8dfa5eafa91ad456fff756a91eca8
Reviewed By: kaiwenw Differential Revision: D26920016 fbshipit-source-id: 76000f76f7ed365719cb2e6678e3e3a2a48d0ed1
Summary: Pull Request resolved: facebookresearch#411 Reviewed By: kaiwenw Differential Revision: D26628972 fbshipit-source-id: 41cca03e5899f5ded4d7d99a07b7ef5c14ca0df0
Summary: Refactor dqn trainer and crr trainer in order to report validation metrics. Reviewed By: igfox Differential Revision: D26817735 fbshipit-source-id: 333b7842fa1a12acc794a17206a7e5fc849f6037
Summary: Pull Request resolved: facebookresearch#417 we need to import final from typing_extensions Reviewed By: MisterTea Differential Revision: D26993309 fbshipit-source-id: 777a0ef4d6189ad4a75e696ae958256b20965bac
Reviewed By: pradeep90 Differential Revision: D27063903 fbshipit-source-id: f8469a04e318db034800e488ec4b360c9da8306a
Summary: Convert and fix Oncall Short Name: oncall_reinforcement_learning Reviewed By: kaiwenw Differential Revision: D26626371 fbshipit-source-id: 9cb06edaa3369c244c8fa6f29126cf237e688476
Differential Revision: D27079703 fbshipit-source-id: a590aa1d22ba70e47eef3eb4c1d61bcc48040b01
Summary: Pull Request resolved: facebookresearch#420 Add some comments, remove useless fields, rename fields Oncall Short Name: oncall_reinforcement_learning Reviewed By: gji1 Differential Revision: D26947158 fbshipit-source-id: 8bd832e323efa26ffbbecabf48172726539d8213
Summary: Pull Request resolved: facebookresearch#424 now, MDNRNNTrainer has been migrated to PytorchLightning, we should migrate CEM Trainer to PytorchLightning as well. This is an adhoc fix. Oncall Short Name: oncall_reinforcement_learning Reviewed By: kaiwenw Differential Revision: D27145258 fbshipit-source-id: c54b97e09d3560e0f3f358eff62e851d60e95edb
Summary: introduced in D26635649 (facebookresearch@0136ba5) https://fb.workplace.com/groups/appliedrl/permalink/2919793174970984/ Reviewed By: czxttkl Differential Revision: D27180718 fbshipit-source-id: 2e6ba10961416aaf70ce5156ff800880a3562c1d
…unctions and classes (facebookresearch#423) Summary: Pull Request resolved: facebookresearch#423 Move functions `create_df_from_replay_buffer`, `set_seed`, `feature_transform`, and `validate_mdp_ids_seq_nums` from fblearner.flow.projects.rl to reagent, as well as class `ProblemDomain` from reagent.core.fb.parameters to reagent.core.parameters so that oss may call them in unit tests. Reviewed By: czxttkl Differential Revision: D27130180 fbshipit-source-id: a06b7e8d5d683bb82a214bdab67b7e7e0ea71f2e
Summary: Pull Request resolved: facebookresearch#419 Add a unit test for Seq2Reward model-based algorithm, to replicate the current integration test in https://fburl.com/diffusion/tctz61f8. This would enable a faster testbed for future explorations (see stacked diff as an example). Reviewed By: czxttkl Differential Revision: D27041945 fbshipit-source-id: ca4b54125debc88a53208ff5489f481faf582e22
…earch#422) Summary: Pull Request resolved: facebookresearch#422 This diff verifes that setting `filter_short_sequence=True` is able to reduce eval mse loss of seq2reward to small values around zero on StringGame data. Reviewed By: czxttkl Differential Revision: D27052147 fbshipit-source-id: e8428039ea72f66e9394d8efd90c1fccd6aeef2a
Summary: Pull Request resolved: facebookresearch#426 - add FinalLayer, enabling specification of sigmoid - CPE use same dataset as training (TODO: figure out why setting table_sample < 100 causes training to not work) - add config for reward model training, for feature importance - enable use of user features - minor refactoring, more user friendly for Reels - add option to override equiv_len during training Reviewed By: czxttkl Differential Revision: D27034687 fbshipit-source-id: 06bc519352334ea990ebcabba6cafd3569255def
Summary: Pull Request resolved: facebookresearch#428 title Reviewed By: czxttkl Differential Revision: D27204048 fbshipit-source-id: f7f7a628247ab48822912d28b30643c5c7de8eac
…moryNetworkInput` (facebookresearch#430) Summary: Pull Request resolved: facebookresearch#430 - fix import errors (remove duplicates + resolve path for train_and_evaluate_generic) - add `from_dict` classmethod to `MemoryNetworkInput` Reviewed By: kaiwenw Differential Revision: D27134600 fbshipit-source-id: 41770d5c3d624f651a41513bc84ad844aafb10ec
Summary: Pull Request resolved: facebookresearch#429 Pull Request resolved: facebookresearch#421 Now, for each model manager, it has an OSS implementation in `reagent.model_manager` and internal implementation in `reagent.model_manager.fb`. The internal version mostly inherits from the OSS counterpart with just a few methods overridden for internal usage. So the code has minimal duplication. Reviewed By: MisterTea Differential Revision: D27073406 fbshipit-source-id: e6192960b8e132f5680adc2222993d9ff18216ef
Reviewed By: zertosh Differential Revision: D27288821 fbshipit-source-id: 7053bbb5f324530378d49e9edf6a45ea702914b3
Summary: Pull Request resolved: facebookresearch#431 We find models exported by jit.script caused QE canary timeout error. One hypothesis is that jit.trace has better performance than jit.script so we should stick to jit.trace whenever possible. Reviewed By: kaiwenw Differential Revision: D27083963 fbshipit-source-id: 32cc81079b67a10f72385a6ac816231ef93e8a91
Summary: Pull Request resolved: facebookresearch#433 One should adjust minibatch_size in reader_optioin Differential Revision: D27383416 fbshipit-source-id: c12458ecc0a9de162a6ce0098e905d044a302533
…rch#434) Summary: Pull Request resolved: facebookresearch#434 Reviewed By: kaiwenw Differential Revision: D27388819 fbshipit-source-id: 94669ef04f4532c9435a78d90e3e0ff3a763ffd1
Summary: title Reviewed By: alexnikulkov Differential Revision: D27340272 fbshipit-source-id: d506c7b7ebd04d5a70d529b0c4f9761a276f9d2a
…#435) Summary: Pull Request resolved: facebookresearch#435 Reviewed By: DavidV17 Differential Revision: D27436575 fbshipit-source-id: cbcc0439fca2e0258a1aac5ceff3ae1bb29258c2
Summary: Add integration tests for model-based sequence model cfeval spark transform Reviewed By: kaiwenw Differential Revision: D27381397 fbshipit-source-id: 64e2473d7805435047f5ac4b830e7c55e9584ae3
Summary: Pull Request resolved: facebookresearch#436 Added some comments Reviewed By: alexnikulkov Differential Revision: D27485489 fbshipit-source-id: 69c48bff53d383b41c092fb219be47e4fa35cce1
Summary: Pull Request resolved: facebookresearch#440 Log values directly to Tensorboard Reviewed By: kaiwenw Differential Revision: D27586324 fbshipit-source-id: a06cbedff28d072fec3bc76626f3945bc556d559
Differential Revision: D31605682 fbshipit-source-id: 6c2d89926ecab45cdbbcdd48058ef3697f94f92b
Summary: Pull Request resolved: facebookresearch#560 Bayesian Optimization Optimizer mutation-based optimization and acquisition function. Reviewed By: czxttkl Differential Revision: D31424105 fbshipit-source-id: 97872516e1c633071f983ebe6b254cbabee7b037
…etworks, independent Thompson sampling, and mutation. (facebookresearch#561) Summary: Pull Request resolved: facebookresearch#561 Bayesian Optimization Optimizer with ensemble of feedforward networks, ITS, and mutation based optimization. Reviewed By: czxttkl Differential Revision: D31424065 fbshipit-source-id: 8ffc1e7fd5de303cd572ea5bcd880429af67d173
Summary: Pull Request resolved: facebookresearch#557 See title Reviewed By: czxttkl Differential Revision: D31524614 fbshipit-source-id: e7aa7996de570f4ff990b402fbd23688a4ed12f4
Differential Revision: D31739112 fbshipit-source-id: d7ab577f32eadf56fa8ad1846a0e916ab9fcb778
… methods to unify (facebookresearch#565) Summary: Pull Request resolved: facebookresearch#565 1. Add 2 Thompson sampling MAB algorithms: 1 for Bernoulli rewards, 1 for Normal rewards 2. Refactor UCB code so that Thompson sampling could reuse as much as possible Reviewed By: czxttkl Differential Revision: D31642370 fbshipit-source-id: c4447a22ad11e1bb9696cf269ea9f45523d22f28
Summary: Pull Request resolved: facebookresearch#566 Adding some tools to evaluate the performance of MAB algorithms in a simple simulated environment Notebook shows how to use this: https://fburl.com/anp/f7y0gzl8 Reviewed By: czxttkl Differential Revision: D31672454 fbshipit-source-id: 32e3d4a8daa8f15a4c777c37f70c7962f949c299
Summary: 1. Add option to estimate reward variance and scale the confidence interval width by SQRT(VAR). 2. Add an option to multiply confidence interval width by a constant scalar to make exploration more/less aggressive 3. Remove UCBTuned algorithm because it is essentially UCB1 + variance estimation Reviewed By: czxttkl Differential Revision: D31741828 fbshipit-source-id: 684788746e2e626228cb522c49b2bafa9179d6fe
Summary: Pull Request resolved: facebookresearch#567 Reviewed By: czxttkl Differential Revision: D31743265 fbshipit-source-id: 3508027a8ab23c8569d4cf416560f1b9a6891752
Summary:
### New commit log messages
6429de894 Add support for `len(datamodule)` (#9895)
Removed the following internal patch which may be conflicting with this change:
```
--- a/fbcode/github/third-party/PyTorchLightning/pytorch-lightning/pytorch_lightning/trainer/connectors/data_connector.py
+++ b/fbcode/github/third-party/PyTorchLightning/pytorch-lightning/pytorch_lightning/trainer/connectors/data_connector.py
@@ -215,6 +215,7 @@
def attach_datamodule(
self, model: "pl.LightningModule", datamodule: Optional["pl.LightningDataModule"] = None
) -> None:
+ datamodule = datamodule or getattr(model, 'datamodule', None)
# If we have a datamodule, attach necessary hooks + dataloaders
if datamodule is None:
return
```
Reviewed By: yifuwang
Differential Revision: D31693305
fbshipit-source-id: 48e58aa6a6f9cdf7029b93663004f9243de5d3d8
Summary: ### New commit log messages efc872731 Add typing for `LightningOptimizer` (#9990) Reviewed By: kandluis Differential Revision: D31736920 fbshipit-source-id: c702caf533fdc02fc3e197dc5f6d525ecc36b411
Summary: ### New commit log messages 43c70ece1 Fix `optimizers` overloads typing annotation (#10069) Reviewed By: yifuwang Differential Revision: D31906058 fbshipit-source-id: 0b895c5c5bcd8f2c5615d03d1b09f98f9eb9a7ff
Summary: Pull Request resolved: facebookresearch#568 `mab` extra doesn't exist Reviewed By: czxttkl Differential Revision: D31768958 fbshipit-source-id: b6e2abe49d3faed16edb7862db7cac56903d8edd
…h#572) Summary: Pull Request resolved: facebookresearch#572 Reviewed By: czxttkl Differential Revision: D31950725 fbshipit-source-id: 39d56c3f08825963e9bcc3e2e544d11f7772c0a5
Summary: Pull Request resolved: facebookresearch#569 I think this error will occur when there is no value to sample (train a fixed subnet): Reviewed By: czxttkl Differential Revision: D31814740 fbshipit-source-id: 5a05abd1fafafd4abf013e6a7fb15fdd95e4f17e
) Summary: Pull Request resolved: facebookresearch#573 Add BCE loss for reward decomposition. BCE loss decomposition loss is defined between avg(p) and avg(y). Reviewed By: czxttkl Differential Revision: D31783145 fbshipit-source-id: fd5c46f406a708ed3f9b9323b70cfdf8252478ec
Summary: Pull Request resolved: facebookresearch#574 Adding a LinUCB trainer and a LinearRegressionUCB model type Reviewed By: czxttkl Differential Revision: D31817255 fbshipit-source-id: 17b65da2dd6cf17d21fe90e1591a0a0cfd3c880f
…acebookresearch#575) Summary: Pull Request resolved: facebookresearch#575 ### New commit log messages 412f0a4d2 Remove deprecated dataloader arguments in Trainer methods (#10325) Reviewed By: tangbinh Differential Revision: D32261342 fbshipit-source-id: 0dc24bb64eeb186f722ba147aa569d2b8af63f84
Summary: By some unknown reason, the coverage tool looks for the source code for '/home/circleci/project/config-3.8.py', a file does not exist on the circle ci test machine. We have to use `report coverage -i` to ignore the error Reference: https://coverage.readthedocs.io/en/6.1.1/cmd.html#cmd-report Reviewed By: alexnikulkov Differential Revision: D32325423 fbshipit-source-id: 24e6b355aff287d22cea9008d58f801b300b9f4d
Summary: Pull Request resolved: facebookresearch#577 Update module lists following https://fb.quip.com/lEbxAN6UzLrS#UUGACAIIXSi Reviewed By: alexnikulkov Differential Revision: D32345725 fbshipit-source-id: fef624a759026ea7727159e22433129466bab399
…arch#576) Summary: Pull Request resolved: facebookresearch#576 Adding an additional argument (info) to post episode callback in Agent to match the post episode callback in replay buffer This is needed for Klotski Reviewed By: czxttkl Differential Revision: D32335744 fbshipit-source-id: 8b46b50057656a9cc5d4c6c40edfda3c90beacb4
…#10403) Summary: ### New commit log messages f9b9cdb0d Remove deprecated accelerator pass through functions in Accelerator (#10403) Reviewed By: edward-io Differential Revision: D32261339 fbshipit-source-id: c6696154be5e349cd1de1796ba396325ae06b831
Differential Revision: D32509203 fbshipit-source-id: 6be89a03e80e4598f604422a9100bf4f56e4db90
Differential Revision: D32513683 fbshipit-source-id: d46220bfd6e398b8254d4de98ae3e947aec82107
Differential Revision: D32515266 fbshipit-source-id: 52b7ac7856fa0c453df69836007c7f1e16697630
Differential Revision: D32516359 fbshipit-source-id: 0327d3690fb85a0adffc682a0051817ee7b30cb1
|
This pull request was exported from Phabricator. Differential Revision: D32516359 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
25 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D32516359