Open
Conversation
mhavasi
suggested changes
Sep 25, 2025
Contributor
mhavasi
left a comment
mhavasi
left a comment
There was a problem hiding this comment.
Hey, thanks for the PR. Can you rebase your branch to main so that we can run the unit tests? We recently added the option to run unit tests on external PRs.
examples/2d_flow_matching.ipynb
Outdated
| { | ||
| "cell_type": "code", | ||
| "execution_count": 8, | ||
| "execution_count": null, |
Contributor
There was a problem hiding this comment.
Can you run the notebook from beginning to end to make sure all the cells are executed once in order? That way the outputs are visible on github.
timonpalm
force-pushed
the
misleading_commands
branch
from
dd1e55b to
f714a46
Compare
timonpalm
force-pushed
the
misleading_commands
branch
from
f7aa017 to
00724ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function
ODESolver.sample()received astep_size=0.5as well as atime_grid. This was a little confusing, as thetime_gridimplied astep_size=0.1, effectively ignoring thestep_size. By just passingstep_size=None, it also reflects more the documentation of that function.I added the
step_sizeto a later cell, where its actually being used.I further deleted two variable initializations which seem to have no use in this or the following cells.