Fix v1.3.2 bug keyboard interrupt bug fix #3087
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously running `nox -l` took about 5 seconds on my machine. After this change, `nox -l` takes about 3 seconds.
Bumps [express](https://github.com/expressjs/express) from 4.17.2 to 4.18.2. - [Release notes](https://github.com/expressjs/express/releases) - [Changelog](https://github.com/expressjs/express/blob/master/History.md) - [Commits](expressjs/express@4.17.2...4.18.2) --- updated-dependencies: - dependency-name: express dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Mutable default parameters are dangerous: https://docs.python-guide.org/writing/gotchas/#mutable-default-arguments
Bumps [json5](https://github.com/json5/json5) from 1.0.1 to 1.0.2. - [Release notes](https://github.com/json5/json5/releases) - [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md) - [Commits](json5/json5@v1.0.1...v1.0.2) --- updated-dependencies: - dependency-name: json5 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Previously the error message for get_class failure-to-locate was imprecise.
Co-authored-by: Jasha <[email protected]>
Co-authored-by: Jasha <[email protected]>
Co-authored-by: Omry Yadan <[email protected]>
Bumps [http-cache-semantics](https://github.com/kornelski/http-cache-semantics) from 4.1.0 to 4.1.1. - [Release notes](https://github.com/kornelski/http-cache-semantics/releases) - [Commits](kornelski/http-cache-semantics@v4.1.0...v4.1.1) --- updated-dependencies: - dependency-name: http-cache-semantics dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
These changes were produced by running `FIX=1 nox -s lint-3.10` This fixes a number of problems reported by the lint tests. This does not fix all errors: bandit still reports security issues due to using pickle.
…esearch#2565) When constructing the config search path, allow callers to directly pass in a non-relative module name starting with `pkg://`. This allows callers to bypass the relative name lookup, and always get consistent behavior regardless of the current environment variables at runtime. This addresses issue facebookresearch#2564. Co-authored-by: Adam Simpkins <[email protected]> Co-authored-by: Jasha <[email protected]>
meta-cla
bot
added
the
CLA Signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR fixes a bug where
on_job_endandon_run_endcallbacks are not executed when the program is interrupted via Ctrl+C (KeyboardInterrupt).Without this fix, cleanup and logging callbacks may be skipped, potentially causing inconsistent state or incomplete logs.
The patch ensures that callbacks are called safely during a KeyboardInterrupt while still allowing the program to terminate normally.
Tested on Hydra v1.3.2.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
MyCallback:main.pyruns a small training loop.on_run_start→on_job_start→ Ctrl+C →on_job_end→on_run_endpytesttest forsafe_invoke_on_interrupt()to ensure callbacks are called.Related Issues and PRs