Skip to content

Commit fb5edb5

Browse files
cdtwiggfacebook-github-bot
authored andcommitted
Change save_gltf_from_skel_states to save_gltf_with_skel_states. (#569)
Summary: "_from" in the new naming scheme is reserved for the source (e.g. bytes), since we use _with_motion, we should use _with_skel_state. Reviewed By: jeongseok-meta Differential Revision: D82411872
1 parent fc37207 commit fb5edb5

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

pymomentum/geometry/geometry_pybind.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -246,7 +246,7 @@ PYBIND11_MODULE(geometry, m) {
246246
// - load_urdf(urdf_filename)
247247
// - load_urdf_from_bytes(urdf_bytes)
248248
// - save_gltf(path, character, fps, motion, offsets, markers)
249-
// - save_gltf_from_skel_states(path, character, fps, skel_states,
249+
// - save_gltf_with_skel_states(path, character, fps, skel_states,
250250
// joint_params, markers)
251251
// - save_fbx(path, character, fps, motion, offsets)
252252
// - save_fbx_with_joint_params(path, character, fps, joint_params)
@@ -890,7 +890,7 @@ support the proprietary momentum motion format for storing model parameters in G
890890
py::arg("markers") =
891891
std::optional<const std::vector<std::vector<momentum::Marker>>>{})
892892
.def_static(
893-
"save_gltf_from_skel_states",
893+
"save_gltf_with_skel_states",
894894
&saveGLTFCharacterToFileFromSkelStates,
895895
py::call_guard<py::gil_scoped_release>(),
896896
R"(Save a character to a gltf file.

0 commit comments

Comments
 (0)