Refactor to remove duplicate code in marker_tracking. #609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
Summary: We have two functions, trackPosesPerframe and trackPosesForFrames, which are largely identical. This kept messing me up because I would add functionality in one of the functions or the other and then be confused why nothing had changed. Looking at the two functions, they perform the same function, we just need to pass in the appropriate set of frames into trackPosesForFrames and add support for temporal coherence. Reviewed By: jeongseok-meta Differential Revision: D82688034
cdtwigg
force-pushed
the
export-D82688034
branch
from
d869a04 to
f08b507
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We have two functions, trackPosesPerframe and trackPosesForFrames, which are largely identical. This kept messing me up because I would add functionality in one of the functions or the other and then be confused why nothing had changed.
Looking at the two functions, they perform the same function, we just need to pass in the appropriate set of frames into trackPosesForFrames and add support for temporal coherence.
Reviewed By: jeongseok-meta
Differential Revision: D82688034