-
Notifications
You must be signed in to change notification settings - Fork 23
Fix C++ destructor template-id syntax error #726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jeongseok-meta has exported this pull request. If you are a Meta employee, you can view the originating Diff in D85457060. |
3 tasks
jeongseok-meta
added a commit
that referenced
this pull request
Oct 24, 2025
Summary: Fixed incorrect template-id syntax in the destructor definition of `MultiposeSolverFunctionT<T>`. Reviewed By: cdtwigg Differential Revision: D85457060
90a923d to
487601d
Compare
jeongseok-meta
added a commit
that referenced
this pull request
Oct 25, 2025
Summary: Fixed incorrect template-id syntax in the destructor definition of `MultiposeSolverFunctionT<T>`. Reviewed By: cdtwigg Differential Revision: D85457060
487601d to
667cfd2
Compare
667cfd2 to
0b63746
Compare
jeongseok-meta
added a commit
that referenced
this pull request
Oct 25, 2025
Summary: Pull Request resolved: #726 Fixed incorrect template-id syntax in the destructor definition of `MultiposeSolverFunctionT<T>`. Reviewed By: cdtwigg Differential Revision: D85457060
jeongseok-meta
added a commit
that referenced
this pull request
Oct 25, 2025
Summary: Pull Request resolved: #726 Fixed incorrect template-id syntax in the destructor definition of `MultiposeSolverFunctionT<T>`. Reviewed By: cdtwigg Differential Revision: D85457060
0b63746 to
62231b9
Compare
…oad the correct commit data. Differential Revision: D85488266
62231b9 to
e109f5e
Compare
jeongseok-meta
added a commit
that referenced
this pull request
Oct 25, 2025
Summary: Pull Request resolved: #726 Fixed incorrect template-id syntax in the destructor definition of `MultiposeSolverFunctionT<T>`. Reviewed By: cdtwigg Differential Revision: D85457060
Summary: Pull Request resolved: #726 Fixed incorrect template-id syntax in the destructor definition of `MultiposeSolverFunctionT<T>`. Reviewed By: cdtwigg Differential Revision: D85457060
e109f5e to
db30109
Compare
|
This pull request has been merged in f03c9c1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Fixed incorrect template-id syntax in the destructor definition of
MultiposeSolverFunctionT<T>.Differential Revision: D85457060