Skip to content

Fix parquet timestamp selection when some columns are invalid types #1199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix parquet timestamp selection when some columns are invalid types #1199

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions plotjuggler_plugins/DataLoadParquet/dataload_parquet.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,12 +212,14 @@ bool DataLoadParquet::readDataFromFile(FileLoadInfo* info, PlotDataMapRef& plot_
//-----------------------------
// Time to parse
int timestamp_column = -1;
auto timestamp_arrow_type = arrow::Type::NA;

for (const auto& info : columns_info)
{
if (info.name == selected_stamp.toStdString())
{
timestamp_column = info.column_index;
timestamp_arrow_type = info.arrow_type;
break;
}
}
Expand Down Expand Up @@ -254,8 +256,7 @@ bool DataLoadParquet::readDataFromFile(FileLoadInfo* info, PlotDataMapRef& plot_
auto timestamp_array = batch->column(timestamp_column);
for (int64_t row = 0; row < batch_rows; row++)
{
const auto ts =
get_arrow_value(timestamp_array, row, columns_info[timestamp_column].arrow_type);
const auto ts = get_arrow_value(timestamp_array, row, timestamp_arrow_type);
timestamp_to_row_index[row] = { ts, row };
}
}
Expand Down
Loading