[RFC] Ignore harmless error #126
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I run lvm with pv's on un-partitioned disks. Unless I ignore this error code here, the searching for labels fails setup-storage. With this it works as expected, but it's not all that pretty. The whole error handling from FAI::execute_ro_command is sort of sus, because the error handleing happens directly in that function, so when it detects a warning, it should just warn, and ignore the result. With this I get: (CMD) parted -sm /dev/sdb unit B print 1> /tmp/SY_fQFB0P0 2> /tmp/QOgCOzFBVU Executing: parted -sm /dev/sdb unit B print (STDERR) Error: /dev/sdb: unrecognised disk label (STDOUT) BYT; (STDOUT) /dev/sdb:4096805658624B:scsi:512:512:unknown:ATA Samsung SSD 860:; Ignoring error parted_3_2 And the relevant information can be parsed from that.
Contributor
Author
|
This is more of a case showing the issue rather then a final solution to the problem. I guess most (all?) returned errors from FAI::execute_ro_command can be just ignored. |
Contributor
|
To me it also seems that we could ignore the errors from execute_ro_command. But it would make some following code obsolete, which makes sure the disk has a disk label. I really fear to break other configs if we just ignore this error, since we do not have many testcases for all different sort of partitioning. For me the usage of unpartitioned disks in LVM is more a rare case, so currently I do like to include your patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I run lvm with pv's on un-partitioned disks.
Unless I ignore this error code here, the searching for labels fails setup-storage.
With this it works as expected, but it's not all that pretty.
The whole error handling from FAI::execute_ro_command is sort of sus, because the error handleing happens directly in that function, so when it detects a warning, it should just warn, and ignore the result.
With this I get:
(CMD) parted -sm /dev/sdb unit B print 1> /tmp/SY_fQFB0P0 2> /tmp/QOgCOzFBVU Executing: parted -sm /dev/sdb unit B print
(STDERR) Error: /dev/sdb: unrecognised disk label
(STDOUT) BYT;
(STDOUT) /dev/sdb:4096805658624B:scsi:512:512:unknown:ATA Samsung SSD 860:; Ignoring error parted_3_2
And the relevant information can be parsed from that.