This repository was archived by the owner on Apr 24, 2026. It is now read-only.
fix(edge): fix loop detector argument shift, infinite loops, and shadow mode suppression#156
Open
levleontiev wants to merge 1 commit into
Open
fix(edge): fix loop detector argument shift, infinite loops, and shadow mode suppression#156levleontiev wants to merge 1 commit into
levleontiev wants to merge 1 commit into
Conversation
…ow mode suppression
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes several bugs in the loop detection logic of
fairvisor/edge:rule_engine.lua: The_callwrapper expects(func, default_value, ...). It was called without adefault_value, causing all arguments passed tobuild_fingerprintto be shifted by one (e.g.,methodreceivedpath). Fixed by adding0as the default value.loop_detector.lua: Table clearing usingwhile #t > 0 do t[#t] = nil endis unsafe in Lua for certain scenarios. Replaced with properforloops._wrap_shadowcall to ensure shadow policies only report but do not block loops._build_decision_from_loop: Added a safety check forloop_result.actionto prevent crashes when the action is missing.valueswas used instead ofkvin_append_sorted_key_values.Testing
path|methodare correctly included in the fingerprint and shadow mode correctly suppresses the rejection.