perf: apply multiple-accumulator SIMD optimization to fmean.c (#824)#829
Closed
SebKrantz wants to merge 1 commit into
Closed
perf: apply multiple-accumulator SIMD optimization to fmean.c (#824)#829SebKrantz wants to merge 1 commit into
SebKrantz wants to merge 1 commit into
Conversation
Extends the loop unrolling optimization from PR #828 (fsum.c) to all ungrouped scalar paths in fmean.c, using FMEAN_N_ACC = 4 independent accumulators to break serial dependency chains and enable SIMD auto-vectorization. Functions updated: - fmean_double_impl: na.rm=TRUE (dual acc/nacc arrays), na.rm=FALSE (acc array) - fmean_double_omp_impl: both paths with reduction(+:acc[:N],nacc[:N]) - fmean_weights_impl: both paths with dual macc/wacc arrays - fmean_weights_omp_impl: both paths with array reduction - fmean_int_omp_impl: both paths with long long acc arrays Grouped functions are unchanged — scatter pattern prevents vectorization. Co-authored-by: Sebastian Krantz <SebKrantz@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends the loop unrolling optimization from PR #828 (fsum.c) to all ungrouped scalar paths in fmean.c, using FMEAN_N_ACC = 4 independent accumulators to break serial dependency chains and enable SIMD auto-vectorization.
Functions updated:
Grouped functions are unchanged — scatter pattern prevents vectorization.
Description
Main Changes
Checklist
Additional Context