fix: patch critical and high security vulnerabilities#7
Merged
Conversation
- Remove hardcoded JWT secret fallback; require JWT_SECRET (>=32 chars) in cloud mode, warn in self-hosted dev mode - Add authMiddleware to KMZ generate route (was completely unprotected) - Add authMiddleware + user_id ownership check to KMZ download route (was an IDOR vulnerability) - Restrict CORS to CORS_ORIGIN env var when set (was open to all origins) - Sanitize error responses in KMZ routes (stop leaking err.message to clients)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JWT_SECRET(>=32 chars) in cloud mode; warn in self-hosted dev modeauthMiddlewareto KMZ generate route (was completely unprotected)authMiddleware+user_idownership check to KMZ download route (was an IDOR vulnerability — any user could download any mission by ID)CORS_ORIGINenv var when set (was open*to all origins)err.messageto clients)