-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Droid/redis performance optimizations #5403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
darpanKumar29
wants to merge
67
commits into
feast-dev:master
Choose a base branch
from
BLACKBUCK-LABS:droid/redis-performance-optimizations
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
67 commits
Select commit
Hold shift + click to select a range
0b362a0
changes
darpanKumar29 4050210
new pb files
darpanKumar29 fd726b0
new pb file addition
darpanKumar29 13cc152
newrelic inmpl
darpanKumar29 0cfe0fc
logs
darpanKumar29 47602a3
logs
darpanKumar29 4e35eb9
new pb file
darpanKumar29 23a1e02
added find loads in pb file
darpanKumar29 7de9f59
added find loads in pb file
darpanKumar29 b6a6a57
new pb file
darpanKumar29 0ab92ea
new pb file
darpanKumar29 b94c7e1
config changes
darpanKumar29 772ff89
config changes
darpanKumar29 65ccdf3
pb file path changes
darpanKumar29 66217de
pb file path changes
darpanKumar29 960722f
redis changes
darpanKumar29 27d7093
cluster changes
darpanKumar29 48ff800
cluster changes
darpanKumar29 3bc3837
cluster changes
darpanKumar29 bd70009
cluster changes
darpanKumar29 d180f8a
cluster changes
darpanKumar29 7a87a4e
redis fetch time
darpanKumar29 6c71e80
redis fetch time
darpanKumar29 b060cb5
logs
darpanKumar29 2089202
logs
darpanKumar29 8f1a85d
logs
darpanKumar29 aa54ef4
logs
darpanKumar29 e363248
redis end point chanfges
darpanKumar29 ac62189
logs removal
darpanKumar29 6f6ce8f
new pb file
darpanKumar29 013c673
code changes
darpanKumar29 b174410
redis changes
darpanKumar29 8fa772b
registry pb file changes
darpanKumar29 c1e335e
new model integration
darpanKumar29 eda0b97
redis endpoint changes
darpanKumar29 11681b0
dsp testing changes
darpanKumar29 29c8f9e
combined proto changes
darpanKumar29 838e1df
pb file changes
darpanKumar29 63b98c1
new pb file
darpanKumar29 3370e40
same pb file changes
darpanKumar29 4181f6b
pb file changes
darpanKumar29 a9fda5d
pb file changes
darpanKumar29 771f3cc
new pb file integration
darpanKumar29 51d7de7
ltr mo project name changes
darpanKumar29 848da4e
pb file changes
darpanKumar29 999d930
pb file changes
darpanKumar29 b932e80
yml changes
darpanKumar29 fa5efe8
yml changes
darpanKumar29 7c082b8
logs changes
darpanKumar29 d7e0578
timeout increase
darpanKumar29 bcbab98
SRP mab pb file
darpanKumar29 e4f5874
pb file changes
darpanKumar29 e42bb47
new pb file integration
darpanKumar29 787e05e
redis endpoint changes
darpanKumar29 79d8219
redis endpoint changes
darpanKumar29 dd692be
new registry file
darpanKumar29 dcec069
fixed threadpool implementation in grpc server
darpanKumar29 b4c1566
increasing fixed thread pool
darpanKumar29 01703f6
redis endpoint changes
darpanKumar29 7bff5c3
redis end point changes
darpanKumar29 031ab25
increase no of threads
darpanKumar29 6311a5b
cached threadpool
darpanKumar29 65f7948
logs for threadpool
darpanKumar29 ea3723e
yml cahnges
darpanKumar29 fd53e89
fest optimization
darpanKumar29 caa2e56
optimisation
darpanKumar29 b280dc7
redis changes
darpanKumar29 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
syntax = "proto3"; | ||
package feast.core; | ||
|
||
option go_package = "github.com/feast-dev/feast/go/protos/feast/core"; | ||
option java_outer_classname = "AggregationProto"; | ||
option java_package = "feast.proto.core"; | ||
|
||
import "google/protobuf/duration.proto"; | ||
|
||
message Aggregation { | ||
string column = 1; | ||
string function = 2; | ||
google.protobuf.Duration time_window = 3; | ||
google.protobuf.Duration slide_interval = 4; | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
syntax = "proto3"; | ||
|
||
package grpc.connector; | ||
|
||
import "google/protobuf/timestamp.proto"; | ||
import "feast/types/Value.proto"; | ||
import "feast/types/EntityKey.proto"; | ||
import "feast/serving/ServingService.proto"; | ||
|
||
option go_package = "github.com/feast-dev/feast/go/protos/feast/serving"; | ||
|
||
message ConnectorFeature { | ||
feast.serving.FeatureReferenceV2 reference = 1; | ||
google.protobuf.Timestamp timestamp = 2; | ||
feast.types.Value value = 3; | ||
} | ||
|
||
message ConnectorFeatureList { | ||
repeated ConnectorFeature featureList = 1; | ||
} | ||
|
||
service OnlineStore { | ||
rpc OnlineRead(OnlineReadRequest) returns (OnlineReadResponse); | ||
} | ||
|
||
message OnlineReadRequest { | ||
repeated feast.types.EntityKey entityKeys = 1; | ||
string view = 2; | ||
repeated string features = 3; | ||
} | ||
|
||
message OnlineReadResponse { | ||
repeated ConnectorFeatureList results = 1; | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
// | ||
// Copyright 2020 The Feast Authors | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// https://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
// | ||
|
||
|
||
syntax = "proto3"; | ||
package feast.core; | ||
|
||
option go_package = "github.com/feast-dev/feast/go/protos/feast/core"; | ||
option java_outer_classname = "DataFormatProto"; | ||
option java_package = "feast.proto.core"; | ||
|
||
// Defines the file format encoding the features/entity data in files | ||
message FileFormat { | ||
// Defines options for the Parquet data format | ||
message ParquetFormat {} | ||
|
||
oneof format { | ||
ParquetFormat parquet_format = 1; | ||
} | ||
} | ||
|
||
// Defines the data format encoding features/entity data in data streams | ||
message StreamFormat { | ||
// Defines options for the protobuf data format | ||
message ProtoFormat { | ||
// Classpath to the generated Java Protobuf class that can be used to decode | ||
// Feature data from the obtained stream message | ||
string class_path = 1; | ||
} | ||
|
||
// Defines options for the avro data format | ||
message AvroFormat { | ||
// Optional if used in a File DataSource as schema is embedded in avro file. | ||
// Specifies the schema of the Avro message as JSON string. | ||
string schema_json = 1; | ||
} | ||
|
||
message JsonFormat { | ||
string schema_json = 1; | ||
} | ||
|
||
// Specifies the data format and format specific options | ||
oneof format { | ||
AvroFormat avro_format = 1; | ||
ProtoFormat proto_format = 2; | ||
JsonFormat json_format = 3; | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,271 @@ | ||
// | ||
// Copyright 2020 The Feast Authors | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// https://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
// | ||
|
||
|
||
syntax = "proto3"; | ||
package feast.core; | ||
|
||
option go_package = "github.com/feast-dev/feast/go/protos/feast/core"; | ||
option java_outer_classname = "DataSourceProto"; | ||
option java_package = "feast.proto.core"; | ||
|
||
import "google/protobuf/duration.proto"; | ||
import "google/protobuf/timestamp.proto"; | ||
import "feast/core/DataFormat.proto"; | ||
import "feast/types/Value.proto"; | ||
import "feast/core/Feature.proto"; | ||
|
||
// Defines a Data Source that can be used source Feature data | ||
// Next available id: 28 | ||
message DataSource { | ||
// Field indexes should *not* be reused. Not sure if fields 6-10 were used previously or not, | ||
// but they are going to be reserved for backwards compatibility. | ||
reserved 6 to 10; | ||
|
||
// Type of Data Source. | ||
// Next available id: 12 | ||
enum SourceType { | ||
INVALID = 0; | ||
BATCH_FILE = 1; | ||
BATCH_SNOWFLAKE = 8; | ||
BATCH_BIGQUERY = 2; | ||
BATCH_REDSHIFT = 5; | ||
STREAM_KAFKA = 3; | ||
STREAM_KINESIS = 4; | ||
CUSTOM_SOURCE = 6; | ||
REQUEST_SOURCE = 7; | ||
PUSH_SOURCE = 9; | ||
BATCH_TRINO = 10; | ||
BATCH_SPARK = 11; | ||
BATCH_ATHENA = 12; | ||
} | ||
|
||
// Unique name of data source within the project | ||
string name = 20; | ||
|
||
// Name of Feast project that this data source belongs to. | ||
string project = 21; | ||
|
||
string description = 23; | ||
|
||
map<string, string> tags = 24; | ||
|
||
string owner = 25; | ||
|
||
SourceType type = 1; | ||
|
||
// Defines mapping between fields in the sourced data | ||
// and fields in parent FeatureTable. | ||
map<string, string> field_mapping = 2; | ||
|
||
// Must specify event timestamp column name | ||
string timestamp_field = 3; | ||
|
||
// (Optional) Specify partition column | ||
// useful for file sources | ||
string date_partition_column = 4; | ||
|
||
// Must specify creation timestamp column name | ||
string created_timestamp_column = 5; | ||
|
||
// This is an internal field that is represents the python class for the data source object a proto object represents. | ||
// This should be set by feast, and not by users. | ||
// The field is used primarily by custom data sources and is mandatory for them to set. Feast may set it for | ||
// first party sources as well. | ||
string data_source_class_type = 17; | ||
|
||
// Optional batch source for streaming sources for historical features and materialization. | ||
DataSource batch_source = 26; | ||
|
||
SourceMeta meta = 50; | ||
|
||
message SourceMeta { | ||
google.protobuf.Timestamp earliestEventTimestamp = 1; | ||
google.protobuf.Timestamp latestEventTimestamp = 2; | ||
} | ||
|
||
// Defines options for DataSource that sources features from a file | ||
message FileOptions { | ||
FileFormat file_format = 1; | ||
|
||
// Target URL of file to retrieve and source features from. | ||
// s3://path/to/file for AWS S3 storage | ||
// gs://path/to/file for GCP GCS storage | ||
// file:///path/to/file for local storage | ||
string uri = 2; | ||
|
||
// override AWS S3 storage endpoint with custom S3 endpoint | ||
string s3_endpoint_override = 3; | ||
} | ||
|
||
// Defines options for DataSource that sources features from a BigQuery Query | ||
message BigQueryOptions { | ||
// Full table reference in the form of [project:dataset.table] | ||
string table = 1; | ||
|
||
// SQL query that returns a table containing feature data. Must contain an event_timestamp column, and respective | ||
// entity columns | ||
string query = 2; | ||
} | ||
|
||
// Defines options for DataSource that sources features from a Trino Query | ||
message TrinoOptions { | ||
// Full table reference in the form of [project:dataset.table] | ||
string table = 1; | ||
|
||
// SQL query that returns a table containing feature data. Must contain an event_timestamp column, and respective | ||
// entity columns | ||
string query = 2; | ||
} | ||
|
||
// Defines options for DataSource that sources features from Kafka messages. | ||
// Each message should be a Protobuf that can be decoded with the generated | ||
// Java Protobuf class at the given class path | ||
message KafkaOptions { | ||
// Comma separated list of Kafka bootstrap servers. Used for feature tables without a defined source host[:port]] | ||
string kafka_bootstrap_servers = 1; | ||
|
||
// Kafka topic to collect feature data from. | ||
string topic = 2; | ||
|
||
// Defines the stream data format encoding feature/entity data in Kafka messages. | ||
StreamFormat message_format = 3; | ||
|
||
// Watermark delay threshold for stream data | ||
google.protobuf.Duration watermark_delay_threshold = 4; | ||
} | ||
|
||
// Defines options for DataSource that sources features from Kinesis records. | ||
// Each record should be a Protobuf that can be decoded with the generated | ||
// Java Protobuf class at the given class path | ||
message KinesisOptions { | ||
// AWS region of the Kinesis stream | ||
string region = 1; | ||
|
||
// Name of the Kinesis stream to obtain feature data from. | ||
string stream_name = 2; | ||
|
||
// Defines the data format encoding the feature/entity data in Kinesis records. | ||
// Kinesis Data Sources support Avro and Proto as data formats. | ||
StreamFormat record_format = 3; | ||
} | ||
|
||
// Defines options for DataSource that sources features from a Redshift Query | ||
message RedshiftOptions { | ||
// Redshift table name | ||
string table = 1; | ||
|
||
// SQL query that returns a table containing feature data. Must contain an event_timestamp column, and respective | ||
// entity columns | ||
string query = 2; | ||
|
||
// Redshift schema name | ||
string schema = 3; | ||
|
||
// Redshift database name | ||
string database = 4; | ||
} | ||
|
||
// Defines options for DataSource that sources features from a Athena Query | ||
message AthenaOptions { | ||
// Athena table name | ||
string table = 1; | ||
|
||
// SQL query that returns a table containing feature data. Must contain an event_timestamp column, and respective | ||
// entity columns | ||
string query = 2; | ||
|
||
// Athena database name | ||
string database = 3; | ||
|
||
// Athena schema name | ||
string data_source = 4; | ||
} | ||
|
||
// Defines options for DataSource that sources features from a Snowflake Query | ||
message SnowflakeOptions { | ||
// Snowflake table name | ||
string table = 1; | ||
|
||
// SQL query that returns a table containing feature data. Must contain an event_timestamp column, and respective | ||
// entity columns | ||
string query = 2; | ||
|
||
// Snowflake schema name | ||
string schema = 3; | ||
|
||
// Snowflake schema name | ||
string database = 4; | ||
|
||
// Snowflake warehouse name | ||
string warehouse = 5; | ||
} | ||
|
||
// Defines options for DataSource that sources features from a spark table/query | ||
message SparkOptions { | ||
// Table name | ||
string table = 1; | ||
|
||
// Spark SQl query that returns the table, this is an alternative to `table` | ||
string query = 2; | ||
|
||
// Path from which spark can read the table, this is an alternative to `table` | ||
string path = 3; | ||
|
||
// Format of files at `path` (e.g. parquet, avro, etc) | ||
string file_format = 4; | ||
} | ||
|
||
// Defines configuration for custom third-party data sources. | ||
message CustomSourceOptions { | ||
// Serialized configuration information for the data source. The implementer of the custom data source is | ||
// responsible for serializing and deserializing data from bytes | ||
bytes configuration = 1; | ||
} | ||
|
||
// Defines options for DataSource that sources features from request data | ||
message RequestDataOptions { | ||
reserved 1; | ||
// Mapping of feature name to type | ||
map<string, feast.types.ValueType.Enum> deprecated_schema = 2; | ||
|
||
repeated FeatureSpecV2 schema = 3; | ||
|
||
} | ||
|
||
// Defines options for DataSource that supports pushing data to it. This allows data to be pushed to | ||
// the online store on-demand, such as by stream consumers. | ||
message PushOptions { | ||
reserved 1; | ||
} | ||
|
||
|
||
// DataSource options. | ||
oneof options { | ||
FileOptions file_options = 11; | ||
BigQueryOptions bigquery_options = 12; | ||
KafkaOptions kafka_options = 13; | ||
KinesisOptions kinesis_options = 14; | ||
RedshiftOptions redshift_options = 15; | ||
RequestDataOptions request_data_options = 18; | ||
CustomSourceOptions custom_options = 16; | ||
SnowflakeOptions snowflake_options = 19; | ||
PushOptions push_options = 22; | ||
SparkOptions spark_options = 27; | ||
TrinoOptions trino_options = 30; | ||
AthenaOptions athena_options = 35; | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need those protos? we have protos in the project now:
https://github.com/feast-dev/feast/blob/master/protos/feast/core/Aggregation.proto