Skip to content

Missing Fields in Notification #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Missing Fields in Notification #284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
06a08c8
Missing Fields in Notification
princenaman Apr 14, 2017
b8d84a6
Notification received when app in background
princenaman Apr 14, 2017
20ec81d
Didn't help!
princenaman Apr 14, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/android/FCMPluginActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,4 +72,4 @@ public void onStop() {
Log.d(TAG, "==> FCMPluginActivity onStop");
}

}
}
2 changes: 2 additions & 0 deletions src/android/MyFirebaseMessagingService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@ public void onMessageReceived(RemoteMessage remoteMessage) {

Map<String, Object> data = new HashMap<String, Object>();
data.put("wasTapped", false);
data.put("title", remoteMessage.getNotification().getTitle());
Copy link

@arindamnayak arindamnayak Apr 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add a null check for " remoteMessage.getNotification()", because you send only data in FCM API , then background notification works - explained here. So in that case, 'remoteMessage.getNotification()' will be null and it will break.

data.put("body", remoteMessage.getNotification().getBody());
for (String key : remoteMessage.getData().keySet()) {
Object value = remoteMessage.getData().get(key);
Log.d(TAG, "\tKey: " + key + " Value: " + value);
Expand Down