Skip to content

Check changelog PR references in CI #1247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
co2plant wants to merge 3 commits into
base: main
Choose a base branch
from
+1,029 −0
Open

Check changelog PR references in CI #1247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2d50c58
Add a script checking changelog PR references
co2plant Oct 5, 2026
ddbce7c
Run the changelog PR reference check in CI
co2plant Oct 5, 2026
c9fcb25
Merge branch 'main' into issue-1236-ci-changelog-pr-reference-check
co2plant Oct 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .github/workflows/main.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,8 +253,19 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v6
with:
# '0' as a string: the number 0 is falsy in expressions
fetch-depth: ${{ github.event_name == 'pull_request' && '0' || '1' }}
- uses: ./.github/actions/setup-mise
- run: mise run check
- if: github.event_name == 'pull_request' && github.repository == 'fedify-dev/fedify'
env:
PR_NUMBER: ${{ github.event.pull_request.number }}
BASE_SHA: ${{ github.event.pull_request.base.sha }}
HEAD_SHA: ${{ github.event.pull_request.head.sha }}
run: >-
mise run --skip-deps check:changelog-pr-refs --
--pr "$PR_NUMBER" --base "$BASE_SHA" --head "$HEAD_SHA"

release-test:
runs-on: ubuntu-latest
Expand Down
4 changes: 4 additions & 0 deletions mise.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,6 +240,10 @@ deno run --allow-read --allow-write scripts/check_versions.ts ...$fix_args ...$s
description = "Ensure @fedify/fixture is only used in **/*.test.ts files"
run = "deno run --allow-read scripts/check_fixture_usage.ts"

[tasks."check:changelog-pr-refs"]
description = "Check that changelog entries added by a pull request reference it"
run = "deno run --allow-read --allow-run=git scripts/check_changelog_pr_refs.ts"

[tasks."check:workspace-protocol"]
description = "Check for invalid workspace: specifiers without version (*, ^, ~)"
run = "deno run --allow-read scripts/check_workspace_protocol.ts"
Expand Down
Loading
Loading