Skip to content

Fix flash attn call #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Edenzzzz wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix flash attn call #142

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
76 changes: 20 additions & 56 deletions yunchang/kernels/attention.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,6 @@ def flash_attn_forward(q, k, v,
assert HAS_FLASH_ATTN, "FlashAttention is not available"
if softmax_scale is None:
softmax_scale = q.shape[-1] ** (-0.5)
if flash_attn.__version__ < '2.6.3':
block_out, _, _, _, _, block_lse, _, _ = _flash_attn_forward(
q,
k,
Expand All @@ -128,68 +127,33 @@ def flash_attn_forward(q, k, v,
alibi_slopes=alibi_slopes,
return_softmax=return_softmax,
)
else:
block_out, block_lse, _, _ = _flash_attn_forward(
q,
k,
v,
dropout_p = dropout_p,
softmax_scale = softmax_scale,
causal=causal,
window_size_left=window_size[0],
window_size_right=window_size[1],
softcap=softcap,
alibi_slopes=alibi_slopes,
return_softmax=return_softmax,
)
return block_out, block_lse

def flash_attn_backward(dout, q, k, v, out, softmax_lse, block_dq_buffer, block_dk_buffer, block_dv_buffer, dropout_p, softmax_scale,
bwd_causal, window_size, softcap, alibi_slopes, deterministic, rng_state):
if softmax_scale is None:
softmax_scale = q.shape[-1] ** (-0.5)
assert HAS_FLASH_ATTN
if flash_attn.__version__ < '2.6.3':
_flash_attn_backward(
dout,
q,
k,
v,
out,
softmax_lse,
block_dq_buffer,
block_dk_buffer,
block_dv_buffer,
dropout_p,
softmax_scale,
bwd_causal,
window_size,
softcap,
alibi_slopes,
deterministic,
rng_state,
)
else:
_flash_attn_backward(
dout,
q,
k,
v,
out,
softmax_lse,
block_dq_buffer,
block_dk_buffer,
block_dv_buffer,
dropout_p,
softmax_scale,
bwd_causal,
window_size[0], # Pass window_size_left
window_size[1], # Pass window_size_right
softcap,
alibi_slopes,
deterministic,
rng_state,
)
_flash_attn_backward(
dout,
q,
k,
v,
out,
softmax_lse,
block_dq_buffer,
block_dk_buffer,
block_dv_buffer,
dropout_p,
softmax_scale,
bwd_causal,
window_size,
softcap,
alibi_slopes,
deterministic,
rng_state,
)



def flash_attn3_func_forward(q, k, v, dropout_p, softmax_scale, causal, window_size, softcap, alibi_slopes, return_softmax):
Expand Down