-
Notifications
You must be signed in to change notification settings - Fork 21
Standardize gap spacing in fern-platform #4145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kgowru
wants to merge
3
commits into
app
Choose a base branch
from
cursor/standardize-gap-spacing-in-fern-platform-380d
base: app
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: kapil <[email protected]>
Cursor Agent can help with this pull request. Just |
The latest updates on your projects. Learn more about Vercel for GitHub.
5 Skipped Deployments
|
Co-authored-by: kapil <[email protected]>
Co-authored-by: kapil <[email protected]>
dannysheridan
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes FER-
Short description of the changes made
Standardized the main container gap in
WebAnalyticsPage.tsx
fromgap-6
(24px) togap-4
(16px).What was the motivation & context behind this PR?
To ensure consistent gap spacing of 16px (1rem) across the Web Analytics dashboard, addressing visual inconsistencies identified by the user.
How has this PR been tested?
The change was verified locally to ensure the correct gap spacing was applied and confirmed by running
npm run lint
andnpm run format
.Slack Thread