Skip to content

Conversation

graycampbell
Copy link
Collaborator

📝 Summary

  • Updated callCount and thrownErrors properties to use checked locks since Int and Error are both Sendable.

🛠️ Type of Change

  • Bug fix (change that fixes an issue)
  • New feature (change that adds functionality)
  • Breaking change (bug fix or feature that is not backwards compatible)
  • Documentation (DocC, API docs, markdown files, templates, etc.)
  • Testing (new tests, updated tests, etc.)
  • Refactoring or code formatting (no logic changes)
  • Updating dependencies (Swift packages, Homebrew, etc.)
  • CI/CD (change to automated workflows)
  • Chore (other maintenance)

🧪 How Has This Been Tested?

  • Existing tests all pass.

🔗 Related PRs or Issues

✅ Checklist

  • I have added relevant tests
  • I have verified all tests pass
  • I have formatted my code using SwiftFormat
  • I have updated documentation (if needed)
  • I have added the appropriate label to my PR
  • I have read the contributing guidelines
  • I agree to follow this project's Code of Conduct

@graycampbell graycampbell requested a review from a team August 1, 2025 17:25
@graycampbell graycampbell self-assigned this Aug 1, 2025
@graycampbell graycampbell requested review from jmarq013, Rspoon3, SajanShrestha11 and gage-halverson-fetch and removed request for a team August 1, 2025 17:25
@graycampbell graycampbell added the chore Maintenance not covered by other labels label Aug 1, 2025
Copy link

codecov bot commented Aug 1, 2025

Codecov Report

❌ Patch coverage is 80.00000% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.65%. Comparing base (68c4ead) to head (e15e85b).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...kPropertyAsyncGetter/MockPropertyAsyncGetter.swift 0.00% 2 Missing ⚠️
...rowingGetter/MockPropertyAsyncThrowingGetter.swift 0.00% 2 Missing ⚠️
...essors/MockPropertyGetter/MockPropertyGetter.swift 0.00% 2 Missing ⚠️
...essors/MockPropertySetter/MockPropertySetter.swift 0.00% 2 Missing ⚠️
...rtyThrowingGetter/MockPropertyThrowingGetter.swift 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #127   +/-   ##
=======================================
  Coverage   69.65%   69.65%           
=======================================
  Files          73       73           
  Lines        4811     4811           
=======================================
  Hits         3351     3351           
  Misses       1460     1460           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@graycampbell graycampbell merged commit 437e8f9 into main Aug 8, 2025
8 checks passed
@graycampbell graycampbell deleted the chore/checked-locks branch August 8, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance not covered by other labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Maintenance] Use checked locks for call count and thrown errors
7 participants