⚡ Optimize payroll recalculation performance#2
Conversation
- Modify `recalcLedgerForYear` to accept a `fromMonth` parameter, skipping recalculation for earlier months. - Update `setTargetNet` to only recalculate from the affected month for the current year. - Update `addSalaryEvent` and `removeSalaryEvent` to use the event's effective month as the start point for recalculation. - Add regression test `usePayrollStore.test.ts` to ensure partial recalculation matches full recalculation results. - Add benchmark `recalc.bench.ts` showing ~1.7x performance improvement for mid-year updates.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Optimized the
recalcLedgerForYearfunction and its call sites (setTargetNet,addSalaryEvent,removeSalaryEvent) to avoid unnecessary recalculations of past months when changes only affect future months.Measured Performance Improvement:
Verified correctness by adding a test case that compares the result of a partial recalculation sequence against a full recalculation from scratch.
PR created automatically by Jules for task 10424390235587861290 started by @fgferre