feat: add dropdown toolbar buttons to Rich Editor - #19278
Merged
danharrin merged 10 commits intoMar 17, 2026
Conversation
leek
marked this pull request as ready for review
February 17, 2026 14:02
danharrin
requested changes
Feb 28, 2026
danharrin
left a comment
Member
There was a problem hiding this comment.
Please refactor the implementation to use an object, such as ToolbarButtonGroup, to configure the groups instead of nested arrays. You could introduce a textualButtons() config method on that object instead of introducing selectModeDropdowns() for the entire editor.
leek
force-pushed
the
feat/rich-editor-dropdown-toolbar-buttons
branch
2 times, most recently
from
March 4, 2026 15:37
a3c559d to
c347058
Compare
Add `ToolbarButtonGroup` config object and `RichEditorDropdownTool` rendering component to group related toolbar buttons into compact dropdown menus. Supports icon-based dropdowns and text-label select mode via `textualButtons()`.
leek
force-pushed
the
feat/rich-editor-dropdown-toolbar-buttons
branch
from
March 4, 2026 15:40
c347058 to
fafdd07
Compare
danharrin
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
toolbarButtons()or by registeringRichEditorDropdownToolinstances intools()RichEditorDropdownToolsupports icon mode (inline row of icons) and select mode (vertical list with labels)paragraphtool to core Rich Editor toolsmenu,menuitem,aria-haspopup)paragraphtoolTest plan
hasToolbarButton()for dropdown options, cache invalidation, and group interopvendor/bin/pest tests/src/Forms/Components/RichEditorTest.php)composer cs)