fix: prevent contained styles from leaking into nested RepeatableEntry items - #19297
Merged
Conversation
Contributor
|
I think that might have been the intended behavior. After this PR there is no way to distinguish these repeaters. |
Member
Author
@webard Thanks for the feedback! However, the reverse case already works --- child contained(true) inside parent contained(false) renders correctly. This asymmetry suggests it's a selector bug rather than intended behavior. |
Member
Author
|
That said, the lack of visual separation between items when contained(false) is used could be worth a separate UX improvement. |
danharrin
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #19285
Use direct child selector to prevent nested RepeatableEntry from inheriting parent's contained styling.
Visual changes
before
after
Functional changes
composer cscommand.