fix: Nested MorphTo relationship path caching - #20255
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes incorrect caching of relationship/attribute path resolution when a table cell’s name traverses a MorphTo relationship and then continues into nested relationships, where the concrete related model can differ per record. It updates the shared caches in HasCellState to avoid reusing derived relationship metadata across records in that scenario, and adds regression tests to validate correct state output with mixed morph types.
Changes:
- Add detection for “nested
MorphTorelationship paths” and bypass relationship/attribute name caching when present. - Adjust
HasCellStatecaching behavior for relationship resolution, attribute name resolution, and “multiple relationship” detection under nestedMorphTo. - Add a dedicated Livewire table fixture and new tests covering nested
MorphTopaths and mixed related model types.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/src/Tables/ColumnTest.php | Adds regression tests for nested relationship state resolution through MorphTo, including mixed morph types. |
| tests/src/Fixtures/Livewire/ImagesTable.php | Introduces a test-only table fixture with nested MorphTo-based columns used by the new tests. |
| packages/support/src/Concerns/HasCellState.php | Prevents caching of relationship/attribute path metadata when the column name includes a nested MorphTo traversal. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.