-
Notifications
You must be signed in to change notification settings - Fork 136
chore: bump filecoin-proofs-api to v19.0 #536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
chore: bump filecoin-proofs-api to v19.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the filecoin-proofs-api
dependency from version 18.1 to 19.0, representing a major version bump that may include breaking changes.
- Upgraded
filecoin-proofs-api
from v18.1 to v19.0
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
looks like we removed |
fix: remove unused sector_size from cache function calls
oh .. those sectorSize arguments go all the way up to the Go API, we should remove it there as well and this would become a breaking change. |
…ntional unused variables chore: prefix sector_size parameters with underscore to indicate intentional unused variables
Ah, just pushed underscoring the parameters, as I believed we still would need them for the Go-code. But I will look into removing them there |
BREAKING CHANGE: ClearCache and ClearSyntheticProofs no longer accept sectorSize parameter.
chore: rustfmt
See #513 for how I've planned it. Though a breaking change is even better if that's possible. |
The error on that one was a timeout. I restarted it and it now passes. |
I think we can just break these. In Lotus they're isolated to here: https://github.com/filecoin-project/lotus/blob/master/storage/sealer/ffiwrapper/sealer_cgo.go In Curio they're in https://github.com/filecoin-project/curio/blob/main/lib/ffi/sdr_funcs.go and one in https://github.com/filecoin-project/curio/blob/main/lib/ffi/snap_funcs.go (cc @LexLuthr). Not having to have sector size at some of these callsites might afford some additional cleanup opportunities, but I haven't looked at it in any detail. So as long as we're bumping a version here to signal breakage, and documenting it, adapting to it upstream shouldn't be hard. |
chore: bump filecoin-proofs-api to v19.0
Breaking Change Note:
Users will need to update their calls from:
The changes are consistent across all layers and properly remove the unused sector_size parameter completely from the API.