change type param to TYPE instead of T for Julia#179
Merged
finsberg merged 2 commits intofinsberg:mainfrom May 4, 2025
Merged
Conversation
Owner
|
Hi @kylebeggs, looks good to me. Just need to update the unit tests :) |
CodSpeed Performance ReportMerging #179 will not alter performanceComparing Summary
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I gave a little effort to trying to figure out how to scan the variable names and check if it clashes with this, but it was not obvious how to do that so for now this is at least a big improvement because a lot of these cell models use
Tas a variable.