Skip to content

change type param to TYPE instead of T for Julia#179

Merged
finsberg merged 2 commits intofinsberg:mainfrom
kylebeggs:main
May 4, 2025
Merged

change type param to TYPE instead of T for Julia#179
finsberg merged 2 commits intofinsberg:mainfrom
kylebeggs:main

Conversation

@kylebeggs
Copy link
Contributor

I gave a little effort to trying to figure out how to scan the variable names and check if it clashes with this, but it was not obvious how to do that so for now this is at least a big improvement because a lot of these cell models use T as a variable.

@finsberg
Copy link
Owner

finsberg commented May 2, 2025

Hi @kylebeggs, looks good to me. Just need to update the unit tests :)

@codspeed-hq
Copy link

codspeed-hq bot commented May 2, 2025

CodSpeed Performance Report

Merging #179 will not alter performance

Comparing kylebeggs:main (80e523a) with main (04a36e5)

Summary

✅ 8 untouched benchmarks

@finsberg finsberg merged commit 6638dea into finsberg:main May 4, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants