feat: Implement UseUserAccessGroup for iOS #1756
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces the `UseUserAccessGroup` method in the Firebase C++ Authentication SDK. This method allows developers to specify a user access group for keychain operations on iOS, enabling keychain sharing between apps from the same developer. It wraps the `[FIRAuth useUserAccessGroup:error:]` Objective-C method. - Added `Auth::UseUserAccessGroup(const char* access_group)` to the public API in `firebase/auth.h`. - Implemented the method for iOS in `auth_ios.mm`, calling the corresponding FIRAuth method and handling potential errors. - Provided no-op stub implementations for Android and desktop platforms, as the functionality is iOS-specific. The method returns `kAuthErrorNone` on success or if it's a no-op on non-iOS platforms. On iOS, it returns an appropriate `AuthError` if the underlying Objective-C method reports an error.
jonsimantov
commented
Jun 27, 2025
auth/src/android/auth_android.cc
Outdated
| @@ -670,6 +670,11 @@ void Auth::UseEmulator(std::string host, uint32_t port) { | |||
| SetEmulatorJni(auth_data_, host.c_str(), port); | |||
| } | |||
|
|
|||
| AuthError Auth::UseUserAccessGroup(const char* access_group) { | |||
| // No-op on Android. | |||
| return kAuthErrorNone; | |||
There was a problem hiding this comment.
Return Unimplemented instead of None
jonsimantov
commented
Jun 27, 2025
auth/src/ios/auth_ios.mm
Outdated
| @@ -590,6 +590,26 @@ void SignInCallback(FIRUser *_Nullable user, NSError *_Nullable error, | |||
| SetEmulatorJni(auth_data_, host.c_str(), port); | |||
| } | |||
|
|
|||
| AuthError Auth::UseUserAccessGroup(const char* access_group) { | |||
| if (!auth_data_) { | |||
| return kAuthErrorNone; // Or appropriate error if auth_data_ is unexpectedly null | |||
There was a problem hiding this comment.
Return Not Initialized error
jonsimantov
commented
Jun 27, 2025
| FIRAuth* fir_auth = AuthImpl(auth_data_); | ||
| NSString* ns_access_group = nil; | ||
| if (access_group) { | ||
| ns_access_group = [NSString stringWithUTF8String:access_group]; |
There was a problem hiding this comment.
Handle an empty string too
This commit incorporates feedback for the `UseUserAccessGroup` method: - Stub implementations for Android and desktop now return `kAuthErrorUnimplemented` instead of `kAuthErrorNone`. - The iOS implementation now returns `kAuthErrorUninitialized` if `auth_data_` is null. - The iOS implementation now treats an empty string for `access_group` the same as `nullptr` (passing `nil` to the Objective-C method).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces the
UseUserAccessGroupmethod in the Firebase C++ Authentication SDK.This method allows developers to specify a user access group for keychain operations on iOS, enabling keychain sharing between apps from the same developer. It wraps the
[FIRAuth useUserAccessGroup:error:]Objective-C method.Auth::UseUserAccessGroup(const char* access_group)to the public API infirebase/auth.h.auth_ios.mm, calling the corresponding FIRAuth method and handling potential errors.The method returns
kAuthErrorNoneon success or if it's a no-op on non-iOS platforms. On iOS, it returns an appropriateAuthErrorif the underlying Objective-C method reports an error.Description
Testing
Type of Change
Place an
xthe applicable box:Notes
Release Notessection ofrelease_build_files/readme.md.